Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: don't log "local QPS is below max threshold" by default #89077

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

knz
Copy link
Contributor

@knz knz commented Sep 30, 2022

Context: #89075

This log message is the 9th most voluminous across the CC fleet. It's not surprising since most stores are idle.
There's no good reason to have it logged by default - it doesn't say anything interesting.
Let's just keep it in traces.

Release note: None

This log message is the 9th most voluminous across the CC fleet.
It's not surprising since most stores are idle.
There's no good reason to have it logged by default - it doesn't say
anything interesting.
Let's just keep it in traces.

Release note: None
@knz knz requested a review from a team as a code owner September 30, 2022 10:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knz
Copy link
Contributor Author

knz commented Sep 30, 2022

thanks

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented Sep 30, 2022

Build succeeded:

@craig craig bot merged commit 3a9f5b8 into cockroachdb:master Sep 30, 2022
@knz knz deleted the 20220930-qps branch September 30, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants